Mx 16271 indexing incoming tokens #325
Conversation
# Conflicts: # integrationtests/valuesIndex_test.go
scripts/script.sh
Outdated
| @@ -1,4 +1,5 @@ | |||
| IMAGE_NAME=elastic-container | |||
| IMAGE_NAME_2=elastic-container-2 | |||
| @@ -119,15 +83,30 @@ func (sit *sovereignIndexTokensHandler) getTokensFromScrs(elasticClient elasticp | |||
| return newTokens, nil | |||
| } | |||
|
|
|||
| func getTokenCollection(hasPrefix bool, tokenIdentifier string) (bool, string) { | |||
| func (sit *sovereignIndexTokensHandler) extractSovereignTokens(tokens []string) []string { | |||
There was a problem hiding this comment.
| func (sit *sovereignIndexTokensHandler) extractSovereignTokens(tokens []string) []string { | |
| func (sit *sovereignIndexTokensHandler) extractNewSovereignTokens(tokens []string) []string { |
| @@ -23,3 +23,9 @@ | |||
| username = "" | |||
| password = "" | |||
| bulk-request-max-size-in-bytes = 4194304 # 4MB | |||
|
|
|||
| [config.main-chain-elastic-cluster] | |||
There was a problem hiding this comment.
maybe you can add a comment here to describe for what is used this section of config
| @@ -75,6 +79,9 @@ func (mrtc *managedRunTypeComponents) CheckSubcomponents() error { | |||
| if check.IfNil(mrtc.rewardTxData) { | |||
| return transactions.ErrNilRewardTxDataHandler | |||
| } | |||
| if check.IfNil(mrtc.indexTokensHandler) { | |||
| return transactions.ErrNilIndexTokensHandler | |||
There was a problem hiding this comment.
maybe you should move transactions.ErrNilIndexTokensHandler in another package, because it is not relayed with the transactions package
There was a problem hiding this comment.
maybe you should rename the file in disalbedIndexTokensHandler or similar
| return "" | ||
| } | ||
|
|
||
| func (sit *sovereignIndexTokensHandler) indexNewTokens(responseTokensInfo []data.ResponseTokenInfoDB, buffSlice *data.BufferSlice) error { |
There was a problem hiding this comment.
maybe you can rename this function in serializeNewTokens
| @@ -33,6 +31,8 @@ type ArgsIndexerFactory struct { | |||
| UseKibana bool | |||
| ImportDB bool | |||
| Sovereign bool | |||
| ESDTPrefix string | |||
There was a problem hiding this comment.
from where do you read the value of this parameter ?
There was a problem hiding this comment.
Added parameter in config.toml
| @@ -13,6 +13,12 @@ import ( | |||
| "github.com/multiversx/mx-chain-es-indexer-go/process/elasticproc/tokeninfo" | |||
| ) | |||
|
|
|||
| // MainChainDatabaseClientHandler defines the actions that sovereign database client handler should do | |||
| type MainChainDatabaseClientHandler interface { | |||
There was a problem hiding this comment.
Shouldn't this have an IsInterfaceNil func as well?
|
|
||
| // NewMainChainElasticClient creates a new sovereign elastic client | ||
| func NewMainChainElasticClient(cfg elasticsearch.Config, indexingEnabled bool) (*mainChainElasticClient, error) { | ||
| esClient, err := NewElasticClient(cfg) |
There was a problem hiding this comment.
This again should've been passed as an interface here, not created within this constructor
| file: ./Dockerfile | ||
| push: true | ||
| file: ./Dockerfile-sovereign | ||
| push: ${{ github.event_name == 'release' && github.event.action == 'published' }} |
There was a problem hiding this comment.
So we will only use github actions for sovereign and remove the regular ones on this branch?
Proposed changes
IndexTokensHandlerTesting procedure